This really could be classed a "fix", since adding support for it when reading broke writing. Now we do the right thing.
This makes sector-alignment a no-op when writing other archive versions. I might make it an error to specify -s with a non-JSF package version.
As it turns out the thing I marked as "header size" is more likely just a discarded revision.
Anyways, to detail this: pak version 5 adds fields to the header for sector alignment. The reader now handles this and reads the sectoralignment TOC entry, which now allows STREAMS (and any other packages with this set?) to extract properly.
Woohoo.
This allows pak writer file data to cleanly come from one of two possible sources:
- A file on the filesystem (in which the PakWriter will open the file, tee it into the package file efficently, and then close it)
- A data buffer (which functions like before)
PakReader however will always output data buffers.
This bug was introduced during refactoring (to allow pmdl export support); it causes the writer to not write any file data.
Additionally the writer now sorts by creation time. I'm not sure if greater or less are the correct order.
................. fuck
This really needs to be cleaned up before I'm willing to call it "good" but ultimately the API changes here needed to be done anyhow
