collabvm/CollabVMAuthServer
11
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity

allow for searching by IP #2

Merged
Elijah merged 3 commits from mallory/CollabVMAuthServer:master into master 2025-01-19 16:44:26 -05:00
Conversation 0 Commits 3 Files changed 3 +21 -2
mallory commented 2025-01-17 22:09:39 -05:00
Member
Copy link
No description provided.
mallory added 1 commit 2025-01-17 22:09:39 -05:00
Elijah requested changes 2025-01-19 16:04:32 -05:00
Dismissed
CollabVMAuthServer/HTTP/AdminRoutes.cs Outdated
@ -464,0 +463,4 @@
IPAddress? filterIp = null;
if (payload.filterIp != null)
{
filterIp = IPAddress.Parse(payload.filterIp);
Elijah commented 2025-01-19 16:03:28 -05:00
Owner
Copy link

This should use TryParse and return an error if false. Current code throws an exception if payload.filterIp is invalid.

This should use TryParse and return an error if false. Current code throws an exception if payload.filterIp is invalid.
Elijah marked this conversation as resolved
CollabVMAuthServer/Properties/launchSettings.json Outdated
@ -0,0 +1,12 @@
{
Elijah commented 2025-01-19 16:04:26 -05:00
Owner
Copy link

preferably delete this file as its unnecessary visual studio autogen crust.

preferably delete this file as its unnecessary visual studio autogen crust.
Elijah marked this conversation as resolved
mallory added 1 commit 2025-01-19 16:15:51 -05:00
Elijah added 1 commit 2025-01-19 16:42:44 -05:00
Elijah approved these changes 2025-01-19 16:44:19 -05:00
Elijah merged commit 1a3224ab0b into master 2025-01-19 16:44:26 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Elijah
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: collabvm/CollabVMAuthServer#2
No description provided.
Delete branch "mallory/CollabVMAuthServer:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?